Disable Surf Music in Caves

rbroab · 2018-10-03 18:24:14

Does anybody know how to disable the music while surfing in a cave? I’ve added custom music to a few caves in Pokemon Crystal, but I don’t want that music to start and stop over and over while I’m surfing in places like Mt Mortar or the Whirl Islands. I’m not looking to disable it all together. I still would like to hear it while surfing outside.

Ragni featured this in one of the caves for Polished Crystal, however I wasn’t able to find the script applied for said function. Any pointers would be appreciated!

Rangi · 2018-10-03 22:35:52

You can solve this kind of question by working backwards. Presumably the code that plays the Surf music must identify that music somewhere. The relevant ID is MUSIC_SURF, so search on GitHub for that. Spoiler: it turns up the SpecialMapMusic routine. Now you can compare it with Polished Crystal's implementation, or even study its logic and figure out where+how to add a check for your cave maps.

Last edited by Rangi (2018-10-03 22:37:33)

rbroab · 2018-10-04 06:00:10

Fantastic help as always. Much appreciated! My only idea was to check the Lugia Chamber map file, but looking at how you’ve scripted this to work for Polished Crystal, it makes much more sense. Going to attempt to replicate the effect in other caves.

rbroab · 2018-10-05 23:42:19

So I was able to replicate the effect, but only for one location. After I added others, I tried compiling the rom and it kept saying error unable to place ‘Home’ at ROM0. I’m guessing the added line of script was making the file too large to compile together. Any advice? What I mean by that is, would there be a way to script it in a way that checks if you’re in a cave rather than individual map groups?

Last edited by rbroab (2018-10-06 16:08:25)

KeiTaRo · 2018-10-22 08:26:29

the map permission is what you want to be polling in this case. something like:

ld a [wPermission]
cp CAVE
jr z, .yourcode

should do the trick

Last edited by KeiTaRo (2018-10-22 08:29:11)

Skeetendo

#1 2018-10-03 18:24:14

Disable Surf Music in Caves

#2 2018-10-03 22:35:52

Re: Disable Surf Music in Caves

#3 2018-10-04 06:00:10

Re: Disable Surf Music in Caves

#4 2018-10-05 23:42:19

Re: Disable Surf Music in Caves

#5 2018-10-22 08:26:29

Re: Disable Surf Music in Caves

Board footer