Skeetendo

’Cause all games were better on the GBC

You are not logged in.

#1 2018-08-04 01:11:07

NobodySociety
Member
Registered: 2018-07-26
Post 2/10

Difficulty adding new features to hack

Hello! I'm trying to port the yellow events for the starter pokemon over to red. I was able to accomplish this on the current pokered, but i recently switched the base to Drenn1's full color hack, and when trying to port the same events i get an error :

ERROR: main.asm(344) -> scripts/vermilioncity.asm(264) -> .func_f1a0f(-1):
    Macro '.func_f1a0f' not defined
make: *** [Makefile:37: main_red.o] Error 5

I'm not entirely certain how to define the macro. I'm very new to rom hacking.

Offline

#2 2018-08-04 15:16:52

Danny-E 33
Administrator
Registered: 2012-06-09
Post 1,104/1,119

Re: Difficulty adding new features to hack

That is a bit of a misleading error message from rgbds when you reference a label that doesn't exist. That isn't supposed to be a macro, but when you reference a label that doesn't exist, rgbds tries to interpret it as a macro.

Take another look at the original scripts/vermilioncity.asm and scripts/vermilioncity2.asm from pokeyellow:
https://github.com/pret/pokeyellow/blob … oncity.asm
https://github.com/pret/pokeyellow/blob … ncity2.asm

And make sure all of your labels on routines match your labels you use to reference those routines.

Offline

#3 2018-08-04 16:27:27

NobodySociety
Member
Registered: 2018-07-26
Post 4/10

Re: Difficulty adding new features to hack

After going over each script, both mine and the two from pokeyellow, i still get the same error. Ive tried renaming it to match what was in yellow, I tried creating two separate scripts and it still gives me the same error. Here is the code:

VermilionCityText15:
TX_ASM
callba .func_f1a0f
jp TextScriptEnd

.func_f1a0f:
ld a, [wPlayerStarter]
cp SQUIRTLE
jr z, .starter_squirtle
CheckEvent EVENT_GOT_SQUIRTLE_FROM_OFFICER_JENNY
jr nz, .asm_f1a69
ld a, [wObtainedBadges]
bit 2, a ; THUNDERBADGE
jr nz, .asm_f1a24
ld hl, OfficerJennyText1
call PrintText
ret

EDIT:
Ok so i figured out what was wrong. When i was copying code over to the vermilioncity.asm some of the labels werent all the way aligned to the left. I backspaced everything so that the string had no empty space between it and the edge of the window. Thanks for the help, i appreciate it.

Last edited by NobodySociety (2018-08-06 15:14:08)

Offline

Board footer

Powered by FluxBB