Skeetendo

’Cause all games were better on the GBC

You are not logged in.

#1 2016-11-13 10:56:39

UberMedic7
Member
From: Greece
Registered: 2013-07-25
Post 34/74

Pokemon Patched Crystal Beta 1.0

Hack name: Pokemon Patched Crystal

Hack of: Pokemon Crystal using the pokecrystal disassembly

The second generation games were revolutionary for their time and still hold up to this day, although they are not perfect.

Introducing Pokemon Patched Crystal!

About the hack:
Pokemon Crystal is a great game, but sadly it suffers from bugs and inaccuracies. This hack is an attempt to fix those but still retain the original feel and content of the game, which means this hack is more of a "patch" rather than a completely new game.

Why you are making this?
When i first found out about the bugs in generation 2 games i was suprised, who would have thought that entire items would be useless or Johto pokemon only appearing in Kanto. The aim of the hack is to fix said bugs and include minor adjustments to gameplay.

What's wrong with the other hacks and why should i play vanilla Crystal with bugfixes?
There's nothing wrong with the other hacks out there if anything they are quite impressive, i just prefer to make the hack as such because to my knowledge nothing like it exists so i thought that someone should get it done or as a man more famous than myself said "I'd like to create a game i would enjoy playing." So think of this hack as my definitive version of crystal.

So a hack with nothing new? Boring!
For some people it might be, but thats ok. You will however be able to catch all 251 pokemon without trades and make use of other vanilla friendly features.

Anything else?
Yes! The thread title says "beta" thats because the game IS playable, but not 100% bug free. Most of the major issues like catchrate glitches or item glitches have been fixed, along with other things. If you want a more detailed list, take a peek at my Github page.

Features
-The majority of bugs have been fixed
-Capture all 251 Pokemon, no trading with friends required
-Adjusted Time System, no longer will you have short mornings or long nights
-Celebi event restored, no more scrambled eggs
-Infinite use TMs, a collector's dream
-All Gym Leaders are available for a rematch, think you can win again?
-And more.... maybe....


Changelog

Github

Latest Version


Screenshots
fEmRgXbRRky6LoUImHhG_A.pnghEuPNOxYTUWyR-eMtqwiLQ.png
bt20j42UQeyBe3H2vvdvfA.pngHdGCPZqzSdOIOkjAiMUTWA.png

Credits:

Pret for the pokecrystal disassembly

Skeetendo and its community for the valuable information

Special Thanks:

Rangi for being ever so helpful along the way.

Pokecrystal's thorough documentation

Last edited by UberMedic7 (2018-09-02 12:31:18)

Offline

#2 2016-11-15 19:36:56

Rangi
Member
Registered: 2016-05-09
Post 325/870

Re: Pokemon Patched Crystal Beta 1.0

Good start! How about putting your code on GitHub? It gives you a "commit history" of changes, which can really help with debugging, and lets people see how you got your features to work. Here's an introduction.

Haunter now evolves into Gengar at level 40. (This was done for testing purposes and kept as is)

Will you change the other trade evolutions too, so they can all be obtained in one game?

In case you haven't seen it, here's a whole list of glitches you may want to fix.

Last edited by Rangi (2016-11-15 19:37:59)


Pokémon Polished Crystal (GitHub) — version 2.2.0 released
Pokémon Red★ and Blue★: Space World Edition (GitHub) — updated August 19!
Polished Map: pokered+pokecrystal map, tileset, and palette editor — version 3.5.1 released!

Offline

#3 2016-11-15 21:36:54

UberMedic7
Member
From: Greece
Registered: 2013-07-25
Post 35/74

Re: Pokemon Patched Crystal Beta 1.0

Rangi wrote:

Good start! How about putting your code on GitHub? It gives you a "commit history" of changes, which can really help with debugging, and lets people see how you got your features to work. Here's an introduction.

Haunter now evolves into Gengar at level 40. (This was done for testing purposes and kept as is)

Will you change the other trade evolutions too, so they can all be obtained in one game?

In case you haven't seen it, here's a whole list of glitches you may want to fix.

Thanks for your reply. I do use the wiki as a reference to bugs and i hope that im capable of fixing them all. As for trade evolutions yes i do plan to change them, I was also considering making friendship eeveelutions a bit faster by decreasing the needed friendship value or maybe turn them into generic stone evolutions. I might give GitHub a shot maybe it will be useful and any feedback is useful.

Offline

#4 2016-11-15 22:08:42

Rangi
Member
Registered: 2016-05-09
Post 327/870

Re: Pokemon Patched Crystal Beta 1.0

If you do change Espeon and Umbreon to use the Sun and Moon Stones, you should update engine/party_menu.asm:PlacePartyMonEvoStoneCompatibility. It only checks the first few entries, so past that it will say "Not able" but evolve anyway.

Last edited by Rangi (2016-11-15 22:08:56)


Pokémon Polished Crystal (GitHub) — version 2.2.0 released
Pokémon Red★ and Blue★: Space World Edition (GitHub) — updated August 19!
Polished Map: pokered+pokecrystal map, tileset, and palette editor — version 3.5.1 released!

Offline

#5 2016-11-15 22:28:17

UberMedic7
Member
From: Greece
Registered: 2013-07-25
Post 36/74

Re: Pokemon Patched Crystal Beta 1.0

Rangi wrote:

If you do change Espeon and Umbreon to use the Sun and Moon Stones, you should update engine/party_menu.asm:PlacePartyMonEvoStoneCompatibility. It only checks the first few entries, so past that it will say "Not able" but evolve anyway.

Thanks for the info. May i also ask how will i upload all of the files in my repository? There's seems to be a 100 file upload limit.

Offline

#6 2016-11-15 23:03:16

Rangi
Member
Registered: 2016-05-09
Post 329/870

Re: Pokemon Patched Crystal Beta 1.0

Upload? Your repository should handle pushing as many files as you want...

I would suggest forking the original pokecrystal. That way if it updates you can merge the changes with your own. Steps:

1. Click "Fork" at the top-right of pret's pokecrystal.
2. Clone your forked pokecrystal locally on your own computer.
3. Copy+paste your "Patched Crystal Beta 0.1" files on top of the cloned ones. Since you started with pret's pokecrystal as a base, most of them should be the same.
4. Commit your changes, and push them to GitHub.
5. Now when you look at your forked project on GitHub, you'll see a commit that summarizes the changes you made.


Pokémon Polished Crystal (GitHub) — version 2.2.0 released
Pokémon Red★ and Blue★: Space World Edition (GitHub) — updated August 19!
Polished Map: pokered+pokecrystal map, tileset, and palette editor — version 3.5.1 released!

Offline

#7 2016-11-16 23:58:34

UberMedic7
Member
From: Greece
Registered: 2013-07-25
Post 37/74

Re: Pokemon Patched Crystal Beta 1.0

Rangi wrote:

Upload? Your repository should handle pushing as many files as you want...

I would suggest forking the original pokecrystal. That way if it updates you can merge the changes with your own. Steps:

1. Click "Fork" at the top-right of pret's pokecrystal.
2. Clone your forked pokecrystal locally on your own computer.
3. Copy+paste your "Patched Crystal Beta 0.1" files on top of the cloned ones. Since you started with pret's pokecrystal as a base, most of them should be the same.
4. Commit your changes, and push them to GitHub.
5. Now when you look at your forked project on GitHub, you'll see a commit that summarizes the changes you made.

I got around of doing so, here's the link if you guys feel like checking it out.

https://github.com/UberMedic7/patched-crystal

Offline

#8 2016-11-17 02:14:00

wisejustin
Member
From: Kanto
Registered: 2015-01-04
Post 71/131

Re: Pokemon Patched Crystal Beta 1.0

i like the idea, but make some events and not like wild starters? like starters like oaks lab after beating the e4 to get 1 kanto starter ect, then legendary events ect?

Offline

#9 2016-11-17 09:26:17

UberMedic7
Member
From: Greece
Registered: 2013-07-25
Post 38/74

Re: Pokemon Patched Crystal Beta 1.0

wisejustin wrote:

i like the idea, but make some events and not like wild starters? like starters like oaks lab after beating the e4 to get 1 kanto starter ect, then legendary events ect?

I did thought of using events for legendaries as for the starters I literally just thought of making them available by either in-game trades or game corner prizes.

Offline

#10 2017-04-04 18:28:19

UberMedic7
Member
From: Greece
Registered: 2013-07-25
Post 39/74

Re: Pokemon Patched Crystal Beta 1.0

Hello everyone, didnt expect an update didnt you? Me too. Well for the very few who were interested in this, im sorry but all the blame is on me. From now on there's probably gonna be more work done, the OP and game got slightly updated and so is my goal on this project. Besides the bugs im aiming for some small gameplay adjustments, one of which is bringing Johto pokemon from Kanto back to Johto for example having Houndour instead of Growlithe in one route and maybe Octillery instead of Tentacruel on the sea and so on, generally change up some encounters but not something extreme so that the game wont be different. Let me know what you think.

Offline

#11 2017-04-05 20:23:48

Pokemon_Master
Member
From: Eastern Kingdom of Mikado
Registered: 2013-05-18
Post 943/951
Website

Re: Pokemon Patched Crystal Beta 1.0

Hello. It is nice to see that you changed he day night system a bit.
Will you add the orange islands in this game?

Offline

#12 2017-04-05 21:46:54

UberMedic7
Member
From: Greece
Registered: 2013-07-25
Post 42/74

Re: Pokemon Patched Crystal Beta 1.0

Pokemon_Master wrote:

Hello. It is nice to see that you changed he day night system a bit.
Will you add the orange islands in this game?

I dont have the knowledge to do so nor its in plans. As for the time system, it felt weird for me how early night came and morning ended. That way not only it is more natural but its also better gameplay wise and to be honest i decided to do this change on a whim and was the reason i resumed work on the project. As for whats next on the list, im a bit troubled about deciding. On one hand, the main goal is to fix the minor bugs the game has, but now that i look into the list there isnt much to go on besides fixing Dragon Fang. One can argue that there's still some bugs but i think some of them arent really spoiling the gameplay plus they require a whole procedure to execute. So i guess what i can do is makes trade evolutions possible without trading and change/add some encounters . If you got something specific in mind let me know.

Offline

#13 2017-04-21 13:07:51

UberMedic7
Member
From: Greece
Registered: 2013-07-25
Post 43/74

Re: Pokemon Patched Crystal Beta 1.0

Still not dead. An item fix and evolution changes for now, more info on the OP. Next up is adding unobtainable pokemon around the world, Their planned locations are mentioned in the encounters and evolutions text file, these are also subject to change, any suggestions welcome.

Last edited by UberMedic7 (2017-04-21 13:21:47)

Offline

#14 2017-04-22 10:24:32

UberMedic7
Member
From: Greece
Registered: 2013-07-25
Post 44/74

Re: Pokemon Patched Crystal Beta 1.0

Rangi wrote:

If you do change Espeon and Umbreon to use the Sun and Moon Stones, you should update engine/party_menu.asm:PlacePartyMonEvoStoneCompatibility. It only checks the first few entries, so past that it will say "Not able" but evolve anyway.


I took a look at that thread you linked but the code seems entirelly different, a little help would be nice.

Offline

#15 2017-04-22 13:08:43

Rangi
Member
Registered: 2016-05-09
Post 627/870

Re: Pokemon Patched Crystal Beta 1.0

UberMedic7 wrote:
Rangi wrote:

If you do change Espeon and Umbreon to use the Sun and Moon Stones, you should update engine/party_menu.asm:PlacePartyMonEvoStoneCompatibility. It only checks the first few entries, so past that it will say "Not able" but evolve anyway.

I took a look at that thread you linked but the code seems entirelly different, a little help would be nice.

Change engine/party_menu.asm:419 "ld bc, $a" to a larger value. I use $10 and it works for at least four Stone evolutions. StringBuffer1 is 24 bytes, so $18 should be OK.


Pokémon Polished Crystal (GitHub) — version 2.2.0 released
Pokémon Red★ and Blue★: Space World Edition (GitHub) — updated August 19!
Polished Map: pokered+pokecrystal map, tileset, and palette editor — version 3.5.1 released!

Offline

#16 2017-04-22 14:37:15

UberMedic7
Member
From: Greece
Registered: 2013-07-25
Post 45/74

Re: Pokemon Patched Crystal Beta 1.0

Rangi wrote:

Change engine/party_menu.asm:419 "ld bc, $a" to a larger value. I use $10 and it works for at least four Stone evolutions. StringBuffer1 is 24 bytes, so $18 should be OK.


That did the trick, Thanks for that. I know its like doing half the work but im having trouble with a couple more things too. Cant seem to find what makes HMs infinite use so i can do the same for TMs, i also cant find what turns on the GS ball event to trigger at Goldenrod.

Offline

#17 2017-04-22 14:48:26

Rangi
Member
Registered: 2016-05-09
Post 628/870

Re: Pokemon Patched Crystal Beta 1.0

UberMedic7 wrote:

That did the trick, Thanks for that. I know its like doing half the work but im having trouble with a couple more things too. Cant seem to find what makes HMs infinite use so i can do the same for TMs, i also cant find what turns on the GS ball event to trigger at Goldenrod.

The simple way to make infinite TMs is to remove the ConsumeTM call (and definition) from engine/tmhm2.asm. But then you'll also probably want to not show "×1" next to every TM, so get rid of this part. And TMs shouldn't be holdable, so give them the CANT_TOSS attribute in items/item_attributes.asm just like HMs. And make sure that exactly one copy of each TM is available in the game, so either don't sell them in the Game Corner and Marts, or rewrite the way that's done so you can't buy duplicates. Here's how I did that.

The GS Ball event is pretty tied up with other mobile functions in maps/GoldenrodPokeComCenter2FMobile.asm. I just wrote my own event for giving the GS Ball, making sure to set EVENT_CAN_GIVE_GS_BALL_TO_KURT, but maybe pokecrystal-restored can help you with the original event.

Last edited by Rangi (2017-04-22 14:54:01)


Pokémon Polished Crystal (GitHub) — version 2.2.0 released
Pokémon Red★ and Blue★: Space World Edition (GitHub) — updated August 19!
Polished Map: pokered+pokecrystal map, tileset, and palette editor — version 3.5.1 released!

Offline

#18 2017-04-22 21:53:35

pagara123
Member
Registered: 2013-11-06
Post 104/118
Website

Re: Pokemon Patched Crystal Beta 1.0

rangi your asm code same as gold offset or in crystal only?

Offline

#19 2017-04-22 22:22:51

Rangi
Member
Registered: 2016-05-09
Post 629/870

Re: Pokemon Patched Crystal Beta 1.0

pagara123 wrote:

rangi your asm code same as gold offset or in crystal only?

No idea. It doesn't matter where the assembler places the code, since you call it by label instead of by offset. There's also no need to worry about free space. You can just write a new routine in-between two others and the one after it gets shifted.

Last edited by Rangi (2017-04-22 22:24:15)


Pokémon Polished Crystal (GitHub) — version 2.2.0 released
Pokémon Red★ and Blue★: Space World Edition (GitHub) — updated August 19!
Polished Map: pokered+pokecrystal map, tileset, and palette editor — version 3.5.1 released!

Offline

#20 2017-04-23 00:00:51

UberMedic7
Member
From: Greece
Registered: 2013-07-25
Post 46/74

Re: Pokemon Patched Crystal Beta 1.0

Rangi wrote:

The GS Ball event is pretty tied up with other mobile functions in maps/GoldenrodPokeComCenter2FMobile.asm. I just wrote my own event for giving the GS Ball, making sure to set EVENT_CAN_GIVE_GS_BALL_TO_KURT, but maybe pokecrystal-restored can help you with the original event.

I looked into the code you refered but again it seems different to me. I do see the event in my file and messed around with it a little but i got nothing.

Offline

#21 2017-04-29 22:24:11

UberMedic7
Member
From: Greece
Registered: 2013-07-25
Post 47/74

Re: Pokemon Patched Crystal Beta 1.0

New version in just a week, check the OP or readme on Github for the changes.

Offline

#22 2017-05-16 12:12:45

UberMedic7
Member
From: Greece
Registered: 2013-07-25
Post 48/74

Re: Pokemon Patched Crystal Beta 1.0

Few more changes again, you can now get evolution stones in goldenrod, few encounter tweaks and the inclusion of Gen 1 legendaries via in-game trades till i figure out how to make special events for them.

Offline

#23 2017-05-17 09:27:39

pagara123
Member
Registered: 2013-11-06
Post 116/118
Website

Re: Pokemon Patched Crystal Beta 1.0

thanks rangi but how to find the routine of the tm hm i try to add new hm and add new ability that like i create to my have i have
tm 46 rock climb
tm 47 dive

Offline

#24 2017-08-20 18:10:06

UberMedic7
Member
From: Greece
Registered: 2013-07-25
Post 54/74

Re: Pokemon Patched Crystal Beta 1.0

Yet another small but relevant patch, gym leader rematches.

Edit: Finally restored the entire Celebi events, quite literally all in a days work. Thread is also slightly updated.

Last edited by UberMedic7 (2017-08-21 18:33:04)

Offline

#25 2017-09-01 05:22:24

SuperEgz
New member
Registered: 2017-09-01
Post 1/8

Re: Pokemon Patched Crystal Beta 1.0

Hi, just looking through your changelog and it looks great! I have noticed that in game the text when setting up your clock labels the old times as morning, day and night. Is it just a graphical change or is this a glitch?

edit: I have noticed Nurse Joy still says Good Morning between 12pm and 1pm. Shouldn't 12 count as Day?

Last edited by SuperEgz (2017-09-01 06:10:27)

Offline

Board footer

Powered by FluxBB