Skeetendo

Using a status effect would either prevent Pinkan Pokémon from being poisoned/burned/etc, or make them lose their color when they get status.

Crystal has a CaughtData byte for each Pokémon that stores its caught location (look at wram.asm, main.asm:SetCaughtData, and event/poke_seer.asm for how it works). You could check this byte when viewing the stat screen, or for a wild battle, check the player's current location and use the Pinkan palette if they're on that island. If you don't care about Poké Seer accuracy, have the Pinkan Berry edit the caught location.

I would suggest editing gfx/pics/palette_pointers.asm so that palette #0 has normal pink and shiny pink, then edit gfx/color.asm:GetMonPalettePointer to only execute "add hl, bc" if the Pokémon is not supposed to be pink.

Last edited by Rangi (2016-09-10 22:04:12)

Yes, they'd all be referencing the 0th/first palette. Just check for PNK status instead of location and your plan should work.

Also, it would be neat if you encounter wild Pokémon that already have the PNK status on Pinkan Island. Kind of like how Pokémon in Headbutt trees are sometimes asleep. (Look around "call CheckSleepingTreeMon" in battle/core.asm.)

Last edited by Rangi (2016-09-10 22:34:03)

I just have another quick question about this, will I have to add a function to check for the PNK status, because it's looking like this:

GetMonPalettePointer:
    ld l, a
    ld h, $0
    add hl, hl
    add hl, hl
    add hl, hl
    ld bc, PokemonPalettes
    add hl, bc
    ret

GetMonNormalOrShinyPalettePointer:
    push bc
    call GetMonPalettePointer
    pop bc
    push hl
    call CheckShininess
    pop hl
    ret nc
rept 4
    inc hl
endr
    ret

How do I tell it "Pokémon is not supposed to be pink?"

My friend is pretty much going off of the anime, but we've been citing some stuff from Naranja as well, because I think Serg!o did a lot right with his hack that we can use. I don't think anything has been mapped yet, but I did make a world map for him (which I believe I've posted in the custom graphics thread).

The PC shouldn't be too big of an issue, since it's a temporary status anyway, I think I'm starting to understand. After implementing the function, I should have to use:

call CheckPink

somewhere in GetMonPalettePointer, but in order to tell it what to do if it's not pink, won't I have to add another function like ".NotShiny"? I apologize, I'm not very good with assembly, referencing the crib sheet I have just tells me what a function does, although bluntly.

EDIT: Oh boy xD So now it seems there's no built in way to just inflict status on pokemon out of battle, so there goes that plan. I'm trying to add a function for the Pinkan Berry but it seems there is only item capability of curing stat effects and not giving them :s

I think I'll go ahead and make it based off of location for now.

Last edited by Kuroko Aizawa (2016-09-10 23:49:15)

Then write one! Look at the code for MiracleBerry and base it on that. The core action would be:

ld a, MON_STATUS
    call GetPartyParamLocation
    ld a, (1 << PNK)
    ld [hl], a

Edit: I haven't tested this, but here's a try:

PinkanBerry:
    ; Choose a Pokémon to use it on
    ld b, PARTYMENUACTION_HEALING_ITEM
    call UseItem_SelectMon
    ; Exit early if the player canceled
    jp c, PinkanBerry_ExitMenu

    ; Get the chosen Pokémon's current status
    ld a, MON_STATUS
    call GetPartyParamLocation
    ; If it's already pink, no effect
    ld a, [hl]
    and (1 << PNK)
    jp nz, NoEffectMessage

    ; Make it pink
    ld a, (1 << PNK)
    ld [hl], a
    ; Play a sound effect
    call Play_SFX_FULL_HEAL

    ; Describe the effect
    ; TODO:
    ; • add PARTYMENUTEXT_MAKE_PINK after the other PARTYMENUTEXT consts in constants/item_constants.asm
    ; • add your text to .MenuActionTexts in engine.party_menu.asm
    ld b, PARTYMENUTEXT_MAKE_PINK
    ld [PartyMenuActionText], a
    call ItemActionTextWaitButton
    ; Use up the Pinkan Berry
    call UseDisposableItem
    call ClearPalettes
    ret

PinkanBerry_ExitMenu:
    ; wItemEffectSucceeded of 0 means it was canceled
    ; it's set to 1 by default before calling PinkanBerry
    xor a
    ld [wItemEffectSucceeded], a
    call ClearPalettes
    ret

Last edited by Rangi (2016-09-11 00:07:48)

const PARTYMENUTEXT_MAKE_PINK

.Text_MakePink:
    text_jump MakePinkText
    db "@"

MakePinkText::
    text_from_ram StringBuffer1
    text " has"
    line "turned pink!"
    done

I've done all of the above. I think all that's left now is somehow connecting checkpink values to the PNK status effect.

Last edited by Kuroko Aizawa (2016-09-11 01:34:25)

Ok, so I tried that out, and everything is still #0's palette by default. Also, the Pinkan Berry is not usable, it can only be given to pokemon to hold. This might be due to me replacing Item19 with the PinkanBerry.

I'm still looking at it, I'll update this post if I figure it out.

EDIT: So I've got a functioning berry in the game, when you use it, it says "(Pokemon) was cured of poison."

Not sure why it's displaying that text, but on top of that it doesn't seem to do anything, as my cyndaquil was still normal status. I'll keep plugging at it :)

Last edited by Kuroko Aizawa (2016-09-11 01:46:24)

Try this:

const_value SET 2
    const PNK
    const PSN
    const BRN
    const FRZ
    const PAR
    const SLP ; 7 turns

Status conditions are stored in one 8-bit byte. Bits 3 to 7 are used for PSN through SLP. Pretty sure 0, 1, and 2 are unused.

Last edited by Rangi (2016-09-11 02:32:23)

So I kept trying to rearrange the constants of the statuses but nothing is really working. The only way I can get the status afflicted to change to something else is by putting PNK at the end, and then it will default to whatever is first in the order. However, if PNK is first in order, it will default to SLP. I don't understand, maybe there is somewhere else I need to define PNK.

; status
const_value SET 2
    const PSN
    const BRN
    const FRZ
    const PAR
    const SLP ; 7 turns
    const PNK

EDIT: So here's an update. I have the PNK status inflicting normally, which is great, but when you go into battle, after selecting a move the status becomes SLP, I've tested this with other status afflictions and others do not have this effect. Still looking into it.

Last edited by Kuroko Aizawa (2016-09-11 17:14:21)

Beautiful, that fixed it, Comet!

That means we are at the last step, which is fixing the check here:

CheckPink:
    push bc
rept 10
    inc bc
endr
    ld a, [bc]
    cp (1 << PNK)
    pop bc
    ret

GetMonPalettePointer:
    call CheckPink ; return 0 in a if not pink, 1 if pink
    jr nz, .pink
    ld l, a
    ld h, $0
    add hl, hl
    add hl, hl
    add hl, hl
    ld bc, PokemonPalettes
    add hl, bc
    ret

.pink:
    ld hl, PokemonPalettes
    ret

Going to need to brush up on my z80 for this, but let's see if I can figure out what's not working here.

EDIT: Correct me if I'm wrong, but I think the issue is in CheckPink. I don't see anything wrong with GetMonPalettePointer.

EDIT2: As far as I can tell it's just checking for status with nothing to relay it to, but I could be mistaken. I suck at this lol.

Last edited by Kuroko Aizawa (2016-09-11 17:49:41)

CheckPink:
    push af
 push bc
    rept 9
    inc bc
endr
    ld a, [bc]
    cp (1 << PNK)
    pop bc
 pop af
    ret

GetMonPalettePointer:
    call CheckPink ; return 0 in a if not pink, 1 if pink
    jr z, .pink
    ld l, a
    ld h, $0
    add hl, hl
    add hl, hl
    add hl, hl
    ld bc, PokemonPalettes
    add hl, bc
    ret

.pink:
    ld hl, PokemonPalettes
    ret

We've nearly got it done now, this code seems to apply to all of the sprites and fixes the palette issues we had, however it still isn't checking for the PNK status properly yet. So close xD