Skeetendo

1. https://github.com/dannye/pokered-gbc/b … .asm#L1712
Just change that line to "EV_LEVEL,XX,GENGAR", where XX is the level.

2. This would proabably be challenging. TM 50 already goes up to ID FA, so if you wanted to triple the number of TMs, item IDs would have to become 16-bit.

3. https://github.com/dannye/pokered-gbc/b … s.asm#L482
Just change that line to "db $FF,12,GEODUDE,14,ONIX,XX,SANDSLASH,YY,KABUTO,0", where XX and YY are the levels for Sandslash and Kabuto.

4. If you put Mew in the dock, you need to add an object to that map (here) and write a script for when you talk to that object (here)

If you want to make the game designer give you Mew, you need to edit his already existing script here.

Yes, just edit this list.

Making item IDs 16-bit could be complicated. Things that immediately come to mind that would need to be modified:
- The player's item bag, and item PC storage
- Other wram addresses for temporary storage of item IDs, like when using an item
- Map object data (data/mapObjects/) which stores item IDs for pick-up items
- Mart inventories
- Plus all the code that works with this data would need to be rewritten to handle the ID in a register pair, instead of a single register. A lot of this code is in scripts/ but not all of it.

For the game designer script, here is the original:

DirectorText: ; 487b2 (12:47b2)
    TX_ASM

    ; check pokédex
    ld hl, wPokedexOwned
    ld b, wPokedexOwnedEnd - wPokedexOwned
    call CountSetBits
    ld a, [wNumSetBits]
    cp 150
    jr nc, .CompletedDex
    ld hl, .GameDesigner
    jr .done
.CompletedDex
    ld hl, .CompletedDexText
.done
    call PrintText
    jp TextScriptEnd

The code that should handle giving the player a Mew should be immediately below ".CompletedDex"
To see how to accomplish it, you can look at how another script does it. For example, the guy from Silph Co that gives you Lapras:

SilphCo7Text1:
; lapras guy
    TX_ASM
    ld a, [wd72e]
    bit 0, a ; got lapras?
    jr z, .givelapras
    CheckEvent EVENT_BEAT_SILPH_CO_GIOVANNI
    jr nz, .savedsilph
    ld hl, .LaprasGuyText
    call PrintText
    jr .done
.givelapras
    ld hl, .MeetLaprasGuyText
    call PrintText
    lb bc, LAPRAS, 15
    call GivePokemon
    jr nc, .done
    ld a, [wSimulatedJoypadStatesEnd]
    and a
    call z, WaitForTextScrollButtonPress
    call EnableAutoTextBoxDrawing
    ld hl, .HeresYourLaprasText
    call PrintText
    ld hl, wd72e
    set 0, [hl]
    jr .done
.savedsilph
    ld hl, .LaprasGuySavedText
    call PrintText
.done
    jp TextScriptEnd

So you need to call GivePokemon while b holds MEW and c holds the level that you want the player to receive. The GivePokemon function sets the carry flag when it is successful, so this script jumps to .done if the carry flag is not set (The player did not receive the Pokemon. The party and current box were full.)

If the carry flag is set (was successful), the script sets a flag and prints .HeresYourLaprasText. Specifically, it sets bit 0 of wd72e. Notice that it checks this flag at the beginning of the script. This is to avoid giving the player a Lapras every time they talk to him. You would have to do a similar thing for your script, and use an unused flag for this event. (there are a ton of them)

I haven't gotten to adding more TMs yet, but I've changed the Fighting Dojo to a Bug Gym, with Scyther or Pinsir as the prize Pokemon. Seems to be working fine, but I haven't changed the name of the gym yet.

If I could add Gen II Bug Pokemon to have some variety in that gym, that would be perfect. I think I saw a tutorial on how to add next gen Pokemon on FireRed but is there a way to do it on Red version?

Honestly I can't wrap my head around hex editing, and I find ASM to be easier. Thanks, I'll try that out.

Well, as the error states, you do not have leafeon.png in pic/monback/ (it is probably named leafeonb.png)

Also, you do not need to edit home.asm
Since you are using the gbc hack, I have already modified that routine, which is why you see RecallBank.
The whole point of this routine, originally, is to determine which bank to look in for a Pokemon's front and back pic, based on its index number.
This makes it very hard to freely move any single Pokemon's pics between different banks.
With the changes I made to that routine, pics can be in any bank, with two conditions.
A Pokemon's front and back pic must be in the same bank, and the last line of each Pokemon's base stats file must be "db BANK(_____PicFront)" where _____PicFront is the label for that Pokemon's front pic.

As far as main.asm, you still need to delete "INCLUDE "data/baseStats/mew.asm"" and you need to add:
LeafeonPicFront::    INCBIN "pic/bmon/leafeon.pic"
LeafeonPicBack::     INCBIN "pic/monback/leafeonb.pic"
anywhere that it fits. I would put it in the same bank as some other pics, just for consistency. Note that all pics are included twice (from bmon/ and gsmon/), because the gbc project allows for you to toggle between gen I and gen II pics.

EDIT:
I think you updated your comment while I was typing mine and you changed the error screenshot.
Unknown symbol means something tried referring to "LeafeonPicBack" but that label doesn't exist anywhere.

Last edited by Danny-E 33 (2015-09-03 04:42:58)

Now the error is _LeafeonDexEntry

I'm assuming it has something to do with the fact that in pokedex_entries.asm it has "; 407f6 (10:47f6)" after original Pokemon such as Growlithe, but nothing after Leafeon?

EDIT: I think I just worked it out. Forgot to add "::" after the text dex entry.

Yep, it worked. Only problem is that Leafeon now looks like a glitch block.

EDIT #2: Fixed it!

Last edited by megamctaco (2015-09-03 05:05:24)

Exactly what it says. Use your favorite image editor (Paint, Gimp etc) and reduce the png to exactly 4 colors.

In your terminal, type "git diff | clip" (there will be no output on the screen, that's okay) then press ctrl+v into hastebin.com, click save and share the link.
Or just join our irc to talk about it in real time.
https://kiwiirc.com/client/irc.freenode.net/?#pret

Okay, so I'm guessing you have never used git before. Typically, you make a few related changes, then make a 'commit' for those changes.
For example, only edit trainer parties and then make a commit named "Modify trainer parties" then add Leafeon and make a commit named "Add Leafeon" etc, instead of having a 7000 line long diff. Because look at the situation your are in now. What useful name can you give to the commit? "Change a bunch of shit"?
I also don't know how you managed to change the mode on all the files in the repo. I don't fully understand the point of file modes, I just know it's annoying to have mode changes in commits for no reason.

Anyway, the corrupt save file is unavoidable. When you add Pokemon, you increase the size of the owned/seen flag arrays in wram/sram which causes the new game to not recognize the old game's save files.

Donphan's Pokedex page is corrupted because you forgot the string terminator character (@) after "ARMOR".

As far as why Eevee evolves into Flareon immediately after evolving into Umbreon, I don't know yet. I tested it with your diff and I get the same bug. I will think on it a bit and let you know if I find out what's wrong.

I wrote a tutorial on adding gender selection. You can find it here.

Cheers Mateo, I'll check that out later.

I've since removed Donphan and added Umbreon and Glaceon (along with Leafeon, which I added yesterday).

Leafeon works perfectly, but my Glaceon and Umbreon have glitched sprites (both front and back). That's the only issue I'm having right now. Do the back sprites need to be 32 x 32 pixels like the others? Other than the glitched sprites, they're fine.

I'm using the sprites of Umbreon and Glaceon from Mateo's Red++ (as a test until I make my own).

EDIT: I got the sprites to work. Turns out I was missing "db BANK(GlaceonPicFront)" at the bottom of the baseStats.asm for each new Pokemon, which is strange because Leafeon had "db 0 ; padding" and the front sprite was working fine but the back sprite wasn't. Changing "db 0 ; padding" to "db BANK(LeafeonPicFront)" doesn't do anything. The front sprite still loads fine while the back sprite is a mess. Whereas Umbreon and Glaceon have both front and back sprites working perfectly now.

EDIT 2: Espeon is added and both sprites work perfectly.

Last edited by megamctaco (2015-09-04 05:54:09)