Skeetendo

’Cause all games were better on the GBC

You are not logged in.

#1 2014-12-08 04:19:13

daMoose52
Member
Registered: 2014-11-14
Post 6/108
Website

Extending Pokedex in ASM

Followed the threads here for adding monsters to the game, have been successful in hacking the hex in to accomplish this thanks to the forum post regarding the same.
Have been tinkering with the ASM, attempting to recreate the same accomplishments in HEX in the ASM, I'm getting far more comfortable with that and writing in new material and its just plain easier to do a lot of the work (I have always hated text editing in-rom; doing this directly is great) and am running into some issues with the Pokedex.
New monsters are good, all of the tests work. Pretty sure I covered the bases on most features, but Pokedex seen & owned entries are still...off. With the way the ASM is marked up it appears I should just have to change the base definition for NUM_POKEMON and the wram addresses adjust themselves, unlike hacking the hex and having to repoint the array.
Thoughts?


Pokemon: Project Neo A Pokemon hack 15 years in the making...

Offline

#2 2014-12-08 09:16:21

stag019
Idea Killer
Registered: 2011-01-05
Post 607/630

Re: Extending Pokedex in ASM

There's one issue with the Pokedex whenever you extend NUM_POKEMON more than 152.
This line right here is a hard coded value of 153. Changing it to

ld b, (NUM_POKEMON + 7) / 8 * 8 + 1

should hopefully fix that.


You can try to hide yourself in this world of pretend; when the paper's crumpled up, it can't be perfect again.

Offline

#3 2014-12-08 20:01:53

comet
Member
Registered: 2012-04-09
Post 491/672

Re: Extending Pokedex in ASM

Or

ld b, (wPokedexSeenEnd - wPokedexSeen) * 8 + 1

You might also run into issues with saving, since most sram values are still static.

Last edited by comet (2014-12-08 20:03:06)

Offline

#4 2014-12-08 20:59:15

daMoose52
Member
Registered: 2014-11-14
Post 7/108
Website

Re: Extending Pokedex in ASM

All good notes :D
I had found that line shortly after posting and set it to "254" and it worked OK, but there were issues. I was thinking of using NUM_POKEMON somehow so I'll give those a go; thanks a lot!


Pokemon: Project Neo A Pokemon hack 15 years in the making...

Offline

Board footer

Powered by FluxBB