Skeetendo

You're right I misread his original question and thought he was wanting to put it into Prism.

At any rate disassembly is easy to use but little documentation.  This will at least get you installed:

https://www.pokecommunity.com/showthread.php?t=378692

The solve is already there.  I posted the disassembly changes in this thread, you can see the commit through the link.

The link to White Crystal is a commit that shows what changes you need to make to a clean disassembly of pokecrystal to "apply" the patch.  The pokecommunity link would show you how to set up pokecrystal so you could work in disassembly.

I found something very odd with my conversion of this to pokecrystal.  Pokemon placed in the day care are correct, even when opening and closing the party menu.  Pokemon that were existing as static sprites in the overworld are incorrect.  For instance the Miltank farm has turned into Tauros.  I looked at the Route.asm file and the sprites at the bottom actually was labeled Tuaros which I tried fixing SPRITE_TAUROS to SPRITE_MILTANK but this led to an error.  On the other hand the Butterfree sprite in the gate between Ilex Forest and Route shows as an Omastar even though it correctly says SPRITE_BUTTERFREE

That did fix the miltank problem as it was pulling tauros.  This does not work for Butterfree (showing as Omanyte) and the poliwag/wrath in Celadon showing as a jumpluff even though its calling poliwag sprite.  Any thoughts on that?

I double checked again...

Just committed the Miltank fix at least

https://github.com/maniac379/White-Crys … its/master

I tried applying this to TPPCrystal251 through disassembly... Even edited each sprite individually. But they still show up as the regular menu sprites.

What am I doing wrong?

I used everything from the github for Ragni's hack. Was there more elsewhere?
copied...
engine/sprites.asm
menu/mon_icons.asm
menu/mon_icons_1.asm
menu/mon_icons_2.asm
constants/pokemon_data_constants.asm

and main.asm

though the main.asm was very different than the one for TPPCrystal251

I had no error messages while compiling
I did make edits to my main.asm. Actually I only added in the part that Ragni had. I edited the engine/mon_icons, and put all sprite files in their proper places. Uploaded it here

https://github.com/rbroab/tppcrystal251rbroab

But I'm not sure what other files I would need to be making edits to.
Ragni's scripts for constants/pokemon_data_constants.asm use constants, while tpp's use EQU $00 through $66. I'm assuming there isn't enough memory to keep this going through $ff
Not sure how to proceed from here. I've hit a wall.

edit: I feel like I've been making this more complicated than I need to. Does someone with more experience than myself know how to apply this to TTPCrystal? I've already got all the sprites, but I feel like TPPCrystal is running on a very different engine than regular pokecrystal. Too much that I can't confidently say I'd know what all needs to be changed in order to make this work.

Last edited by rbroab (2017-06-17 04:12:02)

So a tip for committing.  You changed and committed each file individually and named each commit the same.  It makes it really hard to look at your changes.  You should really changed all the files in one commit and name that commit something related to what you are changing.  I would recommend starting fresh.  Above it looks like you manually edited each sprite gfx?  Use Ragni's commit and download his disassembly at that commit time (Go to a commit file -> view files) and download it.  Then copy paste all the gfx icons.  You can do this with the other files to but there's like additional stuff that he's changed.  Read through my posts to see what I had to fix from Ragni's commit.

I know you spent a lot of time on it, but I find it very hard to look at your changes side by side with either Ragni's or my commit.

I never had that error.  My guess is a formatting/typo in one of the files you changed...(mon_icons.asm?).  Extra tabs and line breaks can cause errors.

That's why I mentioned the formatting.  You could have accidentally overwritten data as well.  Consider making a commit and then using github to compare the changes you made to the changes Rangi made.