[Patch] Extension 255 icons/minis

Chamber_ · 2014-10-28 00:34:28

Thanks to the initiative and support of Soloo993, to the teachings of ASM of Crystal_, and collaboration of Miksy91, comet and Blue Emerald, I expand the number of minis that can be used for display in the menu party and the Daycare, of 38 to 255!! A whole managed for GBC hacks!
(the Daycare only display the first 128 icons fine)

The patch only overwrites data, therefore there is no danger that eliminates game information. The only new data is the graphics, which were stored in $1F0000-1F7FFF (Bank 0x7C and 0x7D ; free banks).

This patch is not compatible with the "Pokemon Editor Ultimate", but you don't need to use it as each pokemon is assigned a value equal to its number of pokedex.
(Don't apply the patch until you finish the use of the "Pokemon Editor Ultimate")

To find each pokemon minisprite graphic the fomula are:

[Index -1] * 0x80 + 1F0000

------------------------------

Download

Extension 255 icons/minis
------------------------------

Additionally, I maintain a project to compile/create all icons/minisprites of the poké-world to give each one the correct graphic.

This is a sample of the patch.

GSC%20Style2.gif Hitmonlee%20GSC%20style2.gif Eeveevolution%20GSC%20Style2.gif

Thanks to Soloo993 for the compendium of animations.

Credits:

Blue Emerald
Soloo993
Chamber
Lake
Neslug
Pikachu253
Ryta

PD: Some graphics are old version and I have not upgraded to the new ones that Blue Emerald created.

Edit:
This is the routine.

GetIcon: ; 8ea1e
; Load icon graphics into VRAM starting from tile hl.

(...)
    ld a, [CurIcon]
    push hl
    ld l, a
    ld h, 0
    add hl, hl
    ld de, IconPointers
    add hl, de
    ld a, [hli]
    ld e, a
    ld d, [hl]
    pop hl
    
    lb bc, BANK(Icons),//------------jump here
    call GetGFXUnlessMobile

    pop hl
    ret
; 8ea3f
----------------
Function8e82b: ; 8e82b
    ld a, e
    call ReadMonMenuIcon
    ld l, a
    ld h, 0
    add hl, hl
    ld de, IconPointers
    add hl, de
    ld a, [hli]
    ld e, a
    ld d, [hl]
    ld b, BANK(Icons)//------------jump here
    ld c, 8
    ret
; 8e83f
----------------
//jump here
call @extendida

@extendida
ld a,[CurIcon]
cp a,$80
jr nc,@mayor
ld bc,$7C08// 7C = Bank ; nueva ubicacion de los graficos
ret
@mayor
ld bc,$7D08// 7D = Bank
ret
----------------

Last edited by Chamber_ (2014-10-28 00:37:24)

Luna · 2014-10-28 01:07:25

One of these days I will fix Pokemon Editor Ultimate to include support for this if I can get around to it. Always thought this was a neat feature you added to your hack, glad you shared it.

Chamber_ · 2014-10-28 01:16:30

Thanks mate!

I still do not know how to create or modify a tool, but someday I would like to learn because almost everything I do in my hack are expansions of data and make it inaccessible to the use of tools.

Miksy91 · 2014-10-28 11:44:59

Wow, nice to see you guys have completed this :)
I'll probably include this patch to my own hack as well when I continue making it once again.

daw · 2014-12-12 22:09:01

Is there way to make these icons colored? I've put a lot of effort on it, but I can't assign specified palette to minisprite. All sprites in menu share the same palette - palette 1 and I've no clue how to change it.

Last edited by daw (2014-12-12 22:09:26)

PaletteTown · 2015-06-10 16:51:43

I've just patched my Gold ROM with this, testing both my ROM Hack and a clean Gold copy, and while the sprites appear fine on the party menu, it's completely screwed up the appearance of the Overworld minisprites.

I was using static Pokemon minisprites as people in the overworld (both indoor and outdoor), which all worked fine until I applied the patch. The glitch that occurs is that when you open the Pokémon party menu (thus seeing the working Party sprites) and then exit and return to the overworld, the Pokémon overworld minisprites have changed to a different Pokémon until you enter/exit a building and thus refresh the map.

So what's going on here? How do I fix it? It's only triggered by opening the Party menu, so are the overworld sprites somehow getting their values changed due to the way the ROM loads/unloads the Party sprite data?

Is there a way to refresh the screen similarly to entering and exit a building, upon closing the party/start menu?

RED · 2015-07-19 13:22:22

Nice Work!

FroggestSpirit · 2015-09-07 13:08:54

Very nice!

LeaderKoko · 2015-11-01 16:23:46

How to exchange/insert that tiles into rom ?

og · 2016-06-04 20:31:21

Hi, the links are broken. Chamber_, can you reupload them?

Pum · 2016-06-05 02:35:56

Chamber is probably not going to come back in some time. For now here are the pictures from the original post :

The link to the IPS file is also down. You can use mine instead

Rangi · 2016-06-05 08:52:25

I was using static Pokemon minisprites as people in the overworld (both indoor and outdoor), which all worked fine until I applied the patch. The glitch that occurs is that when you open the Pokémon party menu (thus seeing the working Party sprites) and then exit and return to the overworld, the Pokémon overworld minisprites have changed to a different Pokémon until you enter/exit a building and thus refresh the map.

I have the same problem, but with compiled assembly, not the .ips patch. As far as I can tell, the icon bank of the last Pokémon in your party is used for all overworld sprites, and bank 1 is used by default. (So if you enter a map with a Magikarp on it, #129 in bank 2, it'll look like a Bulbasaur, #129−128=1 in bank 1. And then your party menu will affect it.) But I have no idea why that happens; the code should be straightforwardly picking the correct bank.

; Extended icon bank routine by com3tiin
; http://www.pokecommunity.com/showthread.php?t=338470
GetExtendedIconBank:
    ld a, [CurIcon]
    cp a, $80
    lb bc, BANK(Icons1), 8
    ret c
    lb bc, BANK(Icons2), 8
    ret

comet · 2016-07-30 16:08:44

diff --git a/engine/mon_icons.asm b/engine/mon_icons.asm
index 6fefd56..d4e34f5 100755
--- a/engine/mon_icons.asm
+++ b/engine/mon_icons.asm
@@ -1,5 +1,6 @@
 LoadOverworldMonIcon: ; 8e82b
     ld a, e
+    ld [CurIcon], a
     call ReadMonMenuIcon
     ld l, a
     ld h, 0

Maniac379 · 2016-08-06 20:54:07

I love these sprites!

The above fix is in Crystal, I'm in Gold. Any idea where the offset is from the patch and can you compare what the difference in the hex code is for me? I'd appreciate it...I'm wondering if it's the same offset or not since the patch works for GSC.

Maniac379 · 2016-09-10 16:32:54

Not being familiar with ASM/disassembly it took me way longer than I care to admit (and with a lot of help from Miksy91) I have fixed the Gold patch listed above.

There should no longer be any overworld sprite errors and the daycare sprites function well.

All I did was add in comets extra instruction and repoint that small routine so I had space.

https://drive.google.com/open?id=0B9hBm … lJFU2xlOGM

SommenRider · 2016-12-14 01:28:29

Maniac379 wrote:

Not being familiar with ASM/disassembly it took me way longer than I care to admit (and with a lot of help from Miksy91) I have fixed the Gold patch listed above.
There should no longer be any overworld sprite errors and the daycare sprites function well.
All I did was add in comets extra instruction and repoint that small routine so I had space.
https://drive.google.com/open?id=0B9hBm … lJFU2xlOGM

Would you be able to post the assembly version?

Maniac379 · 2017-03-01 16:06:21

Anyone know how to put this into a Pokecrystal disassembly? Ha

Kuroko Aizawa · 2017-03-01 20:59:35

Didn't Rangi do it for Polished Crystal?

https://github.com/roukaour/pokecrystal … c04ee6abf3

Maniac379 · 2017-03-24 01:09:09

You are correct, thank you. I did find typo in Rangi work in the file constants/pokemon_data_constants.asm he has FAERY instead of FAIRY in the egg types. For future reference my commit which changes this will be easier to copy paste the files:

https://github.com/maniac379/White-Crys … 7ddac50d4c

EDIT: If referencing above, note that Ragni commit also did not put in Comet's fix. My commit now adds this (Only lines added in engine/mon_icons.asm https://github.com/maniac379/White-Crys … 0098e9df2a)

Last edited by Maniac379 (2017-05-31 22:14:17)

FIQ · 2017-03-26 14:04:55

I believe that is just because the Fairy type is in Polished Crystal, to avoid clashing constants.

Tylusnoir · 2017-03-26 18:13:43

Hi everyone, nice creation we are here!

I have test to put the .IPS file of Pum but my version Crystal PAL (fr) crash everytime. It's only works on NTSC version?

Last edited by Tylusnoir (2017-03-26 18:14:13)

Maniac379 · 2017-03-26 19:40:40

Tylusnoir wrote:

Hi everyone, nice creation we are here!
I have test to put the .IPS file of Pum but my version Crystal PAL (fr) crash everytime. It's only works on NTSC version?

Try it on a PAL clean ROM but I have to imagine it's because Prism was made in pokecrystal so you'd need to edit it as pokecrystal and not by using a patch. My download of prism contained the entire disassembly of it, you'd have to use Cygwin to add in the changes I put in above and make a new Prism ROM with those changes/

Tylusnoir · 2017-03-26 20:06:11

I have tried on clean PAL Version, code unknown and crash instantly.

I didn't have the offsets of PAL version, I can't find anywhere? The French community of Rom-Hacking is very axed on GBA, DS, 3DS... This is why is hard to find. Where is your download of Pokemon Prism? I don't find it in the search bar. Cygwin... I search it on Google but it's a hex editor?

Sorry for all these questions but it's a bit difficult for me.

Maniac379 · 2017-03-26 23:31:34

Tylusnoir wrote:

I have tried on clean PAL Version, code unknown and crash instantly.
I didn't have the offsets of PAL version, I can't find anywhere? The French community of Rom-Hacking is very axed on GBA, DS, 3DS... This is why is hard to find. Where is your download of Pokemon Prism? I don't find it in the search bar. Cygwin... I search it on Google but it's a hex editor?
Sorry for all these questions but it's a bit difficult for me.

I found Prism after searching around the subreddit for a bit. Cygwin is a tool for working in disassembly not hex. It is far superior and easier to use then the old hex editing, tools included. The way it works though is it compiles (creates) the ROM after changes so after just a few changes the offsets for most things would change and that is why you wouldn't simply be able to apply patches anymore. You could imagine off the bat one of the advantages to compiling the ROM is you no longer need to search for free space, repoint data, etc.

Tylusnoir · 2017-03-27 00:10:10

I don't understand the word "subreddit"?

Oh ok, I will try for Cygwin but it's hard to learn how works this software or easy?

Skeetendo

#1 2014-10-28 00:34:28

[Patch] Extension 255 icons/minis

Download

#2 2014-10-28 01:07:25

Re: [Patch] Extension 255 icons/minis

#3 2014-10-28 01:16:30

Re: [Patch] Extension 255 icons/minis

#4 2014-10-28 11:44:59

Re: [Patch] Extension 255 icons/minis

#5 2014-12-12 22:09:01

Re: [Patch] Extension 255 icons/minis

#6 2015-06-10 16:51:43

Re: [Patch] Extension 255 icons/minis

#7 2015-07-19 13:22:22

Re: [Patch] Extension 255 icons/minis

#8 2015-09-07 13:08:54

Re: [Patch] Extension 255 icons/minis

#9 2015-11-01 16:23:46

Re: [Patch] Extension 255 icons/minis

#10 2016-06-04 20:31:21

Re: [Patch] Extension 255 icons/minis

#11 2016-06-05 02:35:56

Re: [Patch] Extension 255 icons/minis

#12 2016-06-05 08:52:25

Re: [Patch] Extension 255 icons/minis

#13 2016-07-30 16:08:44

Re: [Patch] Extension 255 icons/minis

#14 2016-08-06 20:54:07

Re: [Patch] Extension 255 icons/minis

#15 2016-09-10 16:32:54

Re: [Patch] Extension 255 icons/minis

#16 2016-12-14 01:28:29

Re: [Patch] Extension 255 icons/minis

#17 2017-03-01 16:06:21

Re: [Patch] Extension 255 icons/minis

#18 2017-03-01 20:59:35

Re: [Patch] Extension 255 icons/minis

#19 2017-03-24 01:09:09

Re: [Patch] Extension 255 icons/minis

#20 2017-03-26 14:04:55

Re: [Patch] Extension 255 icons/minis

#21 2017-03-26 18:13:43

Re: [Patch] Extension 255 icons/minis

#22 2017-03-26 19:40:40

Re: [Patch] Extension 255 icons/minis

#23 2017-03-26 20:06:11

Re: [Patch] Extension 255 icons/minis

#24 2017-03-26 23:31:34

Re: [Patch] Extension 255 icons/minis

#25 2017-03-27 00:10:10

Re: [Patch] Extension 255 icons/minis

Board footer