Pokemon Crystal Complete! (Now using pokecrystal)

RPD490 · 2014-01-30 04:44:40

Okay okay, so Im just gonna assume that after I compile the baserom from frogg's repository, I just take the pokecrystal.gbc, and put that in the CrystalComplete repository and just go and compile it and it should work, right?

comet · 2014-01-30 05:14:40

You only need to compile CrystalComplete. The base rom is a vanilla Pokemon Crystal rom.

RPD490 · 2014-01-30 05:40:42

Okay well it finally worked, though at the end it said that the baserom.gbc pokecrystal.gbc differ: 335byte line 1, but the game runs fine. Is that error normal?

FroggestSpirit · 2014-01-30 14:10:13

The reason it gives that error, is because the 2 files differ. baserom.gbc is the original crystal, while pokecrystal.gbc is the crystal complete hack. If it said they were the same, it wouldn't be a hack at all.
I'm thinking of starting on voltorb flip today, and since no one told me otherwise, I replaced the level-up theme with the got item theme (like how it was in red)
if you want to change it back, i'm sure you can figure it out in the sfx_pointers.asm (first sfx on the list, titled dex fanfare 50-79)

Edit: here's a mockup. I was able to squeeze out enough palettes to make this possible on the gameboy color

Last edited by FroggestSpirit (2014-01-30 15:31:48)

RPD490 · 2014-01-30 16:09:29

Ah okay.

Also, very nice mock-up for Voltorb Flip :3 Not so much a fan of it in HGSS cuz it was BS they took out the slots for it, but that is pretty nice though. So colorful.

And funny I see LEET in there for the coins :P

RPD490 · 2014-01-30 17:54:01

Hey I got the make pngs command to work and got the png files, cuz I wanted to replace Lance with my OC's sprite, but when I go and try to use the make lzs command, it says that there is no such command. I installed all the tools in the extras folder, as well as install pypng seperately since I didn't seem to have it install.

What should I do?

comet · 2014-01-30 19:03:55

Just build the rom and they should be changed automatically. If you want to compress it manually, run "make gfx/trainers/015.lz".

The instructions Danny linked are outdated since they're from an older revision.

RPD490 · 2014-01-30 19:05:39

Oooh okay

RPD490 · 2014-01-30 22:02:46

You know what you should also add to this hack? The PCC in Goldenrod! I mean sure you won't be able to do much but it is an awesome Pokemon Center regardless, plus you could make an event where you can get the GS Ball there after beating the Elite Four the first time. XD

That is my suggestion though.

RPD490 · 2014-01-30 23:43:14

Okay I dunno why but I realized that the sprite I used to replace Lance never got replaced even after I did what comet said. I just replaced one sprite and that was it. So I went ahead and tried to make the ROM again and it goes into doing the process of I assume recompile all the PNG images back to lzs images and when it gets to main.o, I get this

Any idea why?

Also, I listened to tracks 108 and 109...what are they from cuz I never heard of them. XD

Last edited by RPD490 (2014-01-30 23:52:14)

comet · 2014-01-31 02:10:40

"Section can't contain initialized data or section limit exceeded" means a bank is full. Recompressed images vary in size compared to the originals. Common bottlenecks are monster pics (which are packed to the brim) and tilesets (which aren't compressed effectively yet).

In normal practice, you can solve this by moving data to another bank.

Since you didn't want to recompress anything, run "git checkout *.lz" to restore the old compressed data. Then run "touch gfx/trainers/015.png" to let make know that Lance's pic is still out of date.

You also don't have to replace pics. You can add any png to gfx/trainers/, and add an incbin somewhere like section Pics 19 in gfx/pics.asm. Chances are recompressing Lance's pic will go past the end of the bank anyway (it's completely full), so you'd have to move something out of section Pics 9.

If you have more questions, it might be best to ask on irc.

FroggestSpirit · 2014-01-31 03:03:09

RPD, song 108 is "Pokeathelon Finals" from Pokemon HG/SS, and 109 is the Pokeradar from DPPt. (I might add precussion to this one eventually)

RPD490 · 2014-01-31 03:43:57

Oooooh jeez no wonder why I could recognize them XD Didn't do much of the Pokethelons in HG and I hardly ever play DPPt and even use the PokeRadar.

FroggestSpirit · 2014-01-31 04:05:38

I've chained with the pokeradar for hours, and looked at the ASM in DPPt to see how it worked, I might add it in, but im not sure.
I never once did the Pokeathelon, but it is something I want to do. I love the music to it though

RPD490 · 2014-01-31 05:34:56

Its funny I saw yellowunusedsong.asm in the RBY folder, surprised its not in the game yet. That track is epic sounding XD

FroggestSpirit · 2014-01-31 12:50:45

If you look in music_pointers.asm (music_pointers2.asm id for if you have the mixed music option on), and constants/music_constants.asm, you can add the song to the playlist. I'd say near the end, but make sure that the name and number in the constants corresponds, for example:
at the bottom of music_pointers and/or music pointers 2
dbw BANK(Music_YellowUnsusedSong), Music_YellowUnsusedSong
Music_YellowUnsusedSong is named this, because it is the first line of the songfile
then at the bottom of music constants:
MUSIC_YELLOW_UNUSED_SONG EQU 110
it is 110, because it is the 110th song in music pointers.
Then you can play it by just loading it to de, and calling PlayMusic or PlayMusic2 just like the champion battle theme

Last edited by FroggestSpirit (2014-01-31 12:51:48)

RPD490 · 2014-02-14 04:34:20

Hey Frogg I remembered you linking a link to the Johto Trainer Battle Remix you did. Can I have the link to it again? XD I don't think I was able to see it in the chat at the time for some reason but I remember you linking it.

FroggestSpirit · 2014-02-17 13:50:06

This one? http://www.youtube.com/watch?v=Kz66ulq9MI0

RPD490 · 2014-02-17 17:41:51

Yeah that one, thanks :3

walk_away21 · 2014-02-20 21:55:46

Very cool!

I am new to hacking and would love to do a Crystal hack using this updated disassembly. I love the physical / special update!

My question is, do I want to update stuff like trainers, scripts, and text in the disassembled form and then build the rom and then change the maps from there with GoldMap? I am not sure what the best order to do things would be and any help would be MUCH appreciated. Also, I have a bunch of tools downloaded and a bunch of links saved but I'm not entirely sure what the best tools are to use with Crystal as some are only GS compatible. Anyone have a good list?

Last edited by walk_away21 (2014-02-20 22:49:16)

comet · 2014-02-21 04:15:13

You would do it in reverse (use crystalmap on a rom, then rip out maps and include them in the repository).

That said, there is a basic map editor for pokecrystal and pokered.

To use it, run

python extras/pokemontools/map_editor.py

walk_away21 · 2014-02-21 13:47:57

comet wrote:

You would do it in reverse (use crystalmap on a rom, then rip out maps and include them in the repository).
That said, there is a basic map editor for pokecrystal and pokered.
http://i.imgur.com/WQ9x9ep.png http://i.imgur.com/A5cJkIG.png
To use it, run
python extras/pokemontools/map_editor.py

Thanks. And then what about scripting? Is it possible to do it in the dissassembly but it would have to be done in assembly code? And what's the best scripting tool (if there is one) for Crystal? As it's my first hack, I'm not looking at this moment to make enormous changes but a good place to start.

comet · 2014-02-22 02:09:11

Event scripting is inline.

Commands are loosely based on pksv. A full list is here: https://github.com/kanzure/pokecrystal/ … g-commands

You're also free to add your own commands to the game if there's something the existing ones don't cover.

Example: https://github.com/kanzure/pokecrystal/ … Island.asm

BlueCinnabarSpeechScript: ; 0x1ac9b0

    faceplayer

    loadfont
    2writetext BlueCinnabarSpeechText ; "Who are you? ..."
    closetext
    loadmovesprites

    playsound SFX_WARP_TO
    applymovement 2, BlueLeavingCinnabarMovement ; warp out
    disappear 2

    clearevent EVENT_BLUE_IN_CINNABAR
    end

; 0x1ac9c4

While the file extension is .asm, you can see plainly that there's no asm here.

Last edited by comet (2014-02-22 02:15:40)

AtecainCorp. · 2014-02-22 21:45:08

How the hell patch it on the WINDOWS? Version under in link from ANONFILES do not work like you said.

YORAMRW · 2014-02-24 20:19:47

comet wrote:

You would do it in reverse (use crystalmap on a rom, then rip out maps and include them in the repository).
That said, there is a basic map editor for pokecrystal and pokered.
To use it, run
python extras/pokemontools/map_editor.py

It would be so cool if there was such a music tracker/editor for these disassemblies.

Skeetendo

#51 2014-01-30 04:44:40

Re: Pokemon Crystal Complete! (Now using pokecrystal)

#52 2014-01-30 05:14:40

Re: Pokemon Crystal Complete! (Now using pokecrystal)

#53 2014-01-30 05:40:42

Re: Pokemon Crystal Complete! (Now using pokecrystal)

#54 2014-01-30 14:10:13

Re: Pokemon Crystal Complete! (Now using pokecrystal)

#55 2014-01-30 16:09:29

Re: Pokemon Crystal Complete! (Now using pokecrystal)

#56 2014-01-30 17:54:01

Re: Pokemon Crystal Complete! (Now using pokecrystal)

#57 2014-01-30 19:03:55

Re: Pokemon Crystal Complete! (Now using pokecrystal)

#58 2014-01-30 19:05:39

Re: Pokemon Crystal Complete! (Now using pokecrystal)

#59 2014-01-30 22:02:46

Re: Pokemon Crystal Complete! (Now using pokecrystal)

#60 2014-01-30 23:43:14

Re: Pokemon Crystal Complete! (Now using pokecrystal)

#61 2014-01-31 02:10:40

Re: Pokemon Crystal Complete! (Now using pokecrystal)

#62 2014-01-31 03:03:09

Re: Pokemon Crystal Complete! (Now using pokecrystal)

#63 2014-01-31 03:43:57

Re: Pokemon Crystal Complete! (Now using pokecrystal)

#64 2014-01-31 04:05:38

Re: Pokemon Crystal Complete! (Now using pokecrystal)

#65 2014-01-31 05:34:56

Re: Pokemon Crystal Complete! (Now using pokecrystal)

#66 2014-01-31 12:50:45

Re: Pokemon Crystal Complete! (Now using pokecrystal)

#67 2014-02-14 04:34:20

Re: Pokemon Crystal Complete! (Now using pokecrystal)

#68 2014-02-17 13:50:06

Re: Pokemon Crystal Complete! (Now using pokecrystal)

#69 2014-02-17 17:41:51

Re: Pokemon Crystal Complete! (Now using pokecrystal)

#70 2014-02-20 21:55:46

Re: Pokemon Crystal Complete! (Now using pokecrystal)

#71 2014-02-21 04:15:13

Re: Pokemon Crystal Complete! (Now using pokecrystal)

#72 2014-02-21 13:47:57

Re: Pokemon Crystal Complete! (Now using pokecrystal)

#73 2014-02-22 02:09:11

Re: Pokemon Crystal Complete! (Now using pokecrystal)

#74 2014-02-22 21:45:08

Re: Pokemon Crystal Complete! (Now using pokecrystal)

#75 2014-02-24 20:19:47

Re: Pokemon Crystal Complete! (Now using pokecrystal)

Board footer