[pokered] Party Menu Sprite Palettes

knuxyl · 2018-02-18 09:34:49

I'm kind of new to assembly language with the GB and the documentation on it is confusing as all hell.

I have Danny's party icon routine working 100%, but the sprites use the menu palette and they look bad. I am not sure of the GB's limitation, can I set each pokemon sprite to use their own palette? It would be best to just point to the palette already being used by the front and back sprite.

This is where most of the modifications to allow separate menu sprites to load

LoadNicknameMonSprite:
    call DisableLCD
    xor a
    ld [H_DOWNARROWBLINKCNT2], a
    ld a, [wMonPartySpriteSpecies]
    ld de, vNPCSprites
    call LoadPartyMonSprite
    call EnableLCD
    ld a, [H_SPRITEINDEX]
    push af
    xor a
    ld [H_SPRITEINDEX], a
    call PlacePartyMonSprite
    pop af
    ld [H_SPRITEINDEX], a
    ret

LoadPartyMonSprites:
    call DisableLCD
    ld de, vNPCSprites
    ld hl, wPartySpecies
.loop
    ld a, [hli]
    cp $ff
    jr z, .done
    push hl
    call LoadPartyMonSprite
    pop hl
    jr .loop
.done
    jp EnableLCD

LoadPartyMonSprite:
    push de
    ld [wd11e], a
    predef IndexToPokedex
    xor a
    ld [H_MULTIPLICAND], a
    ld [H_MULTIPLICAND + 1], a
    ld a, [wd11e]
    dec a
    ld [H_MULTIPLICAND + 2], a
    ld a, $80
    ld [H_MULTIPLIER], a
    call Multiply
    ld a, [H_PRODUCT + 2]
    ld h, a
    ld a, [H_PRODUCT + 3]
    ld l, a
    ld a, $3f
    cp h
    ld a, BANK(PartyMonSprites) + 1
    jr c, .gotBank
    ld a, h
    add $40
    ld h, a
    ld a, BANK(PartyMonSprites)
.gotBank
    pop de
    ld bc, $0080
    jp FarCopyData

PlacePartyMonSprite:
    push hl
    push de
    push bc
    ld a, [H_SPRITEINDEX]
    add a
    add a
    add a
    add a
    ld hl, wOAMBuffer
    ld c, a
    ld b, 0
    add hl, bc
    ld a, h
    ld d, a
    ld a, l
    ld e, a
    ld hl, PartyMonOAM
    add hl, bc
    ld bc, $10
    call CopyData
    ld hl, wOAMBuffer
    ld de, wMonPartySpritesSavedOAM
    ld bc, $60
    call CopyData
    pop bc
    pop de
    pop hl
    ret

PartyMonOAM:
    db $10,$10,$00,$00
    db $10,$18,$01,$00
    db $18,$10,$04,$00
    db $18,$18,$05,$00

    db $20,$10,$08,$00
    db $20,$18,$09,$00
    db $28,$10,$0c,$00
    db $28,$18,$0d,$00

    db $30,$10,$10,$00
    db $30,$18,$11,$00
    db $38,$10,$14,$00
    db $38,$18,$15,$00

    db $40,$10,$18,$00
    db $40,$18,$19,$00
    db $48,$10,$1c,$00
    db $48,$18,$1d,$00

    db $50,$10,$20,$00
    db $50,$18,$21,$00
    db $58,$10,$24,$00
    db $58,$18,$25,$00

    db $60,$10,$28,$00
    db $60,$18,$29,$00
    db $68,$10,$2c,$00
    db $68,$18,$2d,$00

I'm just not sure where I could put palette code, or even what that would look like. I would also like to move the sprites 1 pixel to the left, they are too close to their name. Any help would be great, thanks

Here is a screen of the rom in GB mode and then in SGB mode

Last edited by knuxyl (2018-02-18 09:36:13)

knuxyl · 2018-02-18 10:31:34

Also, no matter what I set the mon_palette.asm for newly added pokemon, it still uses a green palette on the stat screen from the party menu, everywhere else it uses the correct palette. Any ideas? Thanks

Danny-E 33 · 2018-02-21 17:10:36

Regarding your first post, there isn't a whole lot more you can do. The SGB is very limited with how many palettes can be loaded at once, so you can't give each sprite its own palette.

Regarding your second post, take a look at the routine SetPal_StatusScreen: in engine/palettes.asm

You will find the line "cp VICTREEBEL + 1"
Since the internal ID order of the Pokemon doesn't match Pokedex order, Victreebel is the "last" Pokemon, not Mew. If you add new Pokemon beyond Victreebel, you need to use the new last Pokemon in this routine.
To be honest, this error checking isn't even that useful.

knuxyl · 2018-02-22 16:30:36

Danny-E 33 wrote:

Regarding your first post, there isn't a whole lot more you can do. The SGB is very limited with how many palettes can be loaded at once, so you can't give each sprite its own palette.
Regarding your second post, take a look at the routine SetPal_StatusScreen: in engine/palettes.asm
You will find the line "cp VICTREEBEL + 1"
Since the internal ID order of the Pokemon doesn't match Pokedex order, Victreebel is the "last" Pokemon, not Mew. If you add new Pokemon beyond Victreebel, you need to use the new last Pokemon in this routine.
To be honest, this error checking isn't even that useful.

Perfect, exactly what I needed. Thanks

Skeetendo

#1 2018-02-18 09:34:49

[pokered] Party Menu Sprite Palettes

#2 2018-02-18 10:31:34

Re: [pokered] Party Menu Sprite Palettes

#3 2018-02-21 17:10:36

Re: [pokered] Party Menu Sprite Palettes

#4 2018-02-22 16:30:36

Re: [pokered] Party Menu Sprite Palettes

Board footer