Skeetendo

’Cause all games were better on the GBC

You are not logged in.

#1 2017-10-13 16:34:52

Maniac379
Member
Registered: 2015-01-15
Post 108/121

Showing Bag Quantity in a TM Mart

I have been taking a break from my ROM hack but before I quit I had tried implementing a number of changes that kept running into roadblocks.  The one I’d like to work on first is this implementation by Rangi to show held item quantity in marts:
https://github.com/jpmac26/polishedcrys … c73ff295c9
This works great except for when it comes to TMs (As that counting script is blank).

I also wanted to add in this sort of notification for when buying a TM/Show TM name somewhere other than the number:
https://github.com/jpmac26/polishedcrys … 2d36301284

This led me down the rabbit hole of adding a new mart type, TMMart.  Basically copying what I could from Rangi’s disassembly, without any real commits to follow (The updates seemed to be spaced out and many little changes in between.  My TM mart crashes the game completely even though at this point it basically is the same code as a regular mart.  Here is my github, the last 2 commits of this branch are my work so far.  My initial implementation I had to remove the new graphics that were added.
https://github.com/maniac379/White-Crys … rtquantity

Basically at this point in time, my first step is to get my TM Mart type to not crash the game.  I know one difference I had to make compared to the commit was in mart.asm under TMMartConfirmPurchase was to use [wCurTMHM] over [CurTMHM].  I did not have [CurTMHM] defined in my disassembly. 

Then I need to figure out how to have the game count TM in inventory.  I realized the code used to count the other inventory items does not have a corresponding variable for TMs (NumBerries is present but not numTMHM, I found something similar but not quite).  Finally I would like to either rename TMs to show the Attack or add in the text before purchasing a TM that says what the TM contains.


---
Pokémon White Crystal
A simple quality of life and gameplay improved hack

Offline

#2 2018-01-22 19:36:03

Maniac379
Member
Registered: 2015-01-15
Post 113/121

Re: Showing Bag Quantity in a TM Mart

Wow it’s been 3 months!  BUMP


---
Pokémon White Crystal
A simple quality of life and gameplay improved hack

Offline

#3 2018-01-24 10:11:09

Miksy91
Member
Registered: 2010-10-16
Post 2,319/2,339

Re: Showing Bag Quantity in a TM Mart

Relates basically only the second problem you were having, but TMs are stored (at least in Gold/Silver) in a table in such way that there is only a single byte telling, how many of that TM you have in your inventory at the moment. See D57E - D5AF here: https://datacrystal.romhacking.net/wiki … e_Settings

There is no need for storing item number for each TM specifically because there's also no possibility for the player to select the order in how TMs appear in the TM/HM pocket.

Last edited by Miksy91 (2018-01-24 10:13:45)

Offline

Board footer

Powered by FluxBB