Skeetendo

’Cause all games were better on the GBC

You are not logged in.

  • Index
  • → Help/Question
  • → Crystal (but also Gold) add 2 trainer classes for view the pics

#1 2016-10-25 21:56:46

Halfshadow
Member
From: Italy - Lucca
Registered: 2012-04-24
Post 192/260

Crystal (but also Gold) add 2 trainer classes for view the pics

Rangi please can you add the feature for see the trainer pics and the new 2 trainer classes in a clean Crystal rom?


The italian Pokémon Green creator.

Offline

#2 2016-10-26 00:37:06

daMoose52
Member
Registered: 2014-11-14
Post 108/108
Website

Re: Crystal (but also Gold) add 2 trainer classes for view the pics

I've not done this for GSC, but I have done similar pokered; Mateo said he copied the routine to display the Pokemon pics yes? So essentially do the same; copy the routine for Pokemon pics, tweak the variables to look for the trainers and not Pokemon, and call that revised routine when you want to display the trainer pics.


Pokemon: Project Neo A Pokemon hack 15 years in the making...

Offline

#3 2016-10-26 00:47:04

Mateo
Member
From: The Sims 4
Registered: 2009-11-25
Post 3,425/3,535

Re: Crystal (but also Gold) add 2 trainer classes for view the pics

Hope it's ok with Rangi if I post this.

https://github.com/roukaour/pokecrystal … bd118ed3c0

Offline

#4 2016-10-26 01:08:53

Rangi
Member
Registered: 2016-05-09
Post 268/840

Re: Crystal (but also Gold) add 2 trainer classes for view the pics

Mateo wrote:

Hope it's ok with Rangi if I post this.

https://github.com/roukaour/pokecrystal … bd118ed3c0

No problem. :) And yeah, Halfshadow, if you apply those changes to regular pret pokecrystal, the ROM will be just like a clean Crystal ROM except with the fossils added.


ROM hack: Pokémon Polished Crystal (GitHub) — version 2.2.0 released!

Offline

#5 2018-01-12 21:30:39

Halfshadow
Member
From: Italy - Lucca
Registered: 2012-04-24
Post 196/260

Re: Crystal (but also Gold) add 2 trainer classes for view the pics

Someone could tell me how I could use these links please? :D I don't know these files, I know could appear boring, but I need help to know how assembly the repositary files to a ROM.

I have to replace some files with the updated trainer classes from these two repositary, right? Seems to be 18 files, there is also the new script command, when the command is added how hex byte call the trainer pic via script? Or I can simply use a PKSVUI script string to compile the museum script?


The italian Pokémon Green creator.

Offline

#6 2018-01-12 21:52:11

Mateo
Member
From: The Sims 4
Registered: 2009-11-25
Post 3,514/3,535

Re: Crystal (but also Gold) add 2 trainer classes for view the pics

They have instructions. Please read INSTALL.MD and get back to us if you have problems.

Offline

#7 2018-01-13 16:29:19

Halfshadow
Member
From: Italy - Lucca
Registered: 2012-04-24
Post 198/260

Re: Crystal (but also Gold) add 2 trainer classes for view the pics

Installed all like said in the install.md but if I write the string like in the instruction I obtain this:

og4wW7y.png

However are you sure that the fossils classes are the only changes by a clean Crystal? I found something else in the repository, like HG/SS musics as example. But I made other changes myself to my Crystal, there is a way to obtain only the trainer classes with fossils sprite and new script command to see their pic?

P.S. there is a way to paste the string for the command line? Isn't impossible for me and I have to rewrite all myself.


The italian Pokémon Green creator.

Offline

#8 2018-01-13 16:44:15

Ammako
Member
Registered: 2016-03-06
Post 135/158

Re: Crystal (but also Gold) add 2 trainer classes for view the pics

You're supposed to enter the lines one by one (and also I'm not sure where the "bash" at the beginning of your command came from.)

You should be able to paste with shift+insert (or just right-click --> Paste)

Last edited by Ammako (2018-01-13 16:46:16)

Offline

#9 2018-01-13 16:53:15

Halfshadow
Member
From: Italy - Lucca
Registered: 2012-04-24
Post 199/260

Re: Crystal (but also Gold) add 2 trainer classes for view the pics

Nope, the right mouse button is disabled, I open the program using the default bat.

Or I have to use the Windows CMD? But which exe I have to open with the CMD? And in the program drive I have to put the hacked repository downloaded form Github? If yes in which subdrive?


The italian Pokémon Green creator.

Offline

#10 2018-01-13 18:40:15

Ammako
Member
Registered: 2016-03-06
Post 136/158

Re: Crystal (but also Gold) add 2 trainer classes for view the pics

Run via mintty.exe in Cygwin bin folder. Cygwin install should have given you a shortcut to that in your start menu.

Start menu shortcut sets terminal to home folder automatically, if you run mintty.exe manually then you'll have to cd ~ first.

If you want to run it via the .bat, which runs everything in windows cmd (not entirely sure how functional that is compared to Cygwin terminal), you can right-click the window's title bar, hit Properties, and check QuickEdit mode. Then right-clicking will automatically paste clipboard contents.

Last edited by Ammako (2018-01-13 18:44:18)

Offline

#11 2018-01-13 18:42:52

Halfshadow
Member
From: Italy - Lucca
Registered: 2012-04-24
Post 200/260

Re: Crystal (but also Gold) add 2 trainer classes for view the pics

Ok, I have to have the hacked repository in a subdrive or download automatically from github?


The italian Pokémon Green creator.

Offline

#12 2018-01-13 18:47:19

Ammako
Member
Registered: 2016-03-06
Post 137/158

Re: Crystal (but also Gold) add 2 trainer classes for view the pics

git clone --recursive https://github.com/pret/pokecrystal in Cygwin terminal is plenty. cd pokecrystal after to set Cygwin terminal into pokecrystal folder and you can compile with make

Offline

#13 2018-01-13 19:14:09

Halfshadow
Member
From: Italy - Lucca
Registered: 2012-04-24
Post 201/260

Re: Crystal (but also Gold) add 2 trainer classes for view the pics

OMG I don't know how I have to do now.

0DEcAEV.png

I don't have a good feeling with the command line 'cause is very touchy 'cause you have to type correctly all the addresses and commands, and however I don't know if the error is on the folders or something else.

The original Crystal disassemly from Github have to be present? Have to be in the pokecrystal folder that have to be in the minty.exe folder? And I have to replace the hacked files in the pokecrystal drive to assembly the hacked rom? If I'm wrong what folders and files are necessary and where have to be?

Is very confusional for me.

Last edited by Halfshadow (2018-01-13 19:16:13)


The italian Pokémon Green creator.

Offline

#14 2018-01-14 00:51:00

Ammako
Member
Registered: 2016-03-06
Post 138/158

Re: Crystal (but also Gold) add 2 trainer classes for view the pics

(You don't need to use bash like that. Where did you get that from?)

You should really read INSTALL.md like Mateo told you to. You didn't install the required packages.
When you get to "Select Packages" in the installer, change View to "Full" and you can enter the package name in the search bar. Find the packages of the exact same name (nothing more, nothing less), you install them by clicking "Skip" which will change it to a version number (indicating that this is the version of the package that will be installed, it selects the latest version automatically.) Hit Next to finalize the install.

Don't need to uninstall Cygwin to do this, you can just run setup.exe again and you can add onto your existing install. I also recommend you check the option to add a shortcut to Desktop or Start Menu and use that to run Cygwin terminal so you'll be in home folder by default (or do "cd ~")
You were working in /usr/bin/ here, which I guess isn't the end of the world, but I guess it could get messy so it's easier to just keep it to home folder.

Last edited by Ammako (2018-01-14 00:53:14)

Offline

#15 2018-01-14 01:05:13

Halfshadow
Member
From: Italy - Lucca
Registered: 2012-04-24
Post 202/260

Re: Crystal (but also Gold) add 2 trainer classes for view the pics

In the Install.md instruction tell that I have to install:

for 32-bit.

Run setup and leave the default settings. At "Select Packages", choose to install the following:

- `make`
- `git`
- `gcc-core`

Then download [**rgbds**]

But in full like you said I can only view this stuff:

d51wqZv.png

And is a lot of stuff, I can't find make, git and gcc-core, also I installed all the stuff related to the "make` `git` `python" like said in the install.md of the hacked repository using the search box and it installed about 5 GB of stuff that don't work. Is normal that install many stuff?


The italian Pokémon Green creator.

Offline

#16 2018-01-14 01:32:18

Ammako
Member
Registered: 2016-03-06
Post 139/158

Re: Crystal (but also Gold) add 2 trainer classes for view the pics

Ammako wrote:

You didn't install the required packages.
When you get to "Select Packages" in the installer, change View to "Full" and you can enter the package name in the search bar. Find the packages of the exact same name (nothing more, nothing less), you install them by clicking "Skip" which will change it to a version number (indicating that this is the version of the package that will be installed, it selects the latest version automatically.) Hit Next to finalize the install.

Last edited by Ammako (2018-01-14 01:32:33)

Offline

#17 2018-01-14 02:18:34

Halfshadow
Member
From: Italy - Lucca
Registered: 2012-04-24
Post 203/260

Re: Crystal (but also Gold) add 2 trainer classes for view the pics

He made this:

IrViRZK.png

and end with this:

rVbjQPc.png

I had a folder "pokecrystal" with the original Crystal github repository in the bin folder, however I don't know what the terminal did. I can't find any complete rom however.

However to obtain a rom with the hacked repository, I have to replace the files?


The italian Pokémon Green creator.

Offline

#18 2018-01-14 14:40:38

Halfshadow
Member
From: Italy - Lucca
Registered: 2012-04-24
Post 204/260

Re: Crystal (but also Gold) add 2 trainer classes for view the pics

What mean with "segmentation fault"? and how I can solve?


The italian Pokémon Green creator.

Offline

#19 2018-01-14 15:18:15

Ammako
Member
Registered: 2016-03-06
Post 140/158

Re: Crystal (but also Gold) add 2 trainer classes for view the pics

Refer to this post by Danny-E

https://hax.iimarckus.org/post/46257/#p46257

Offline

#20 2018-01-14 15:29:08

Halfshadow
Member
From: Italy - Lucca
Registered: 2012-04-24
Post 205/260

Re: Crystal (but also Gold) add 2 trainer classes for view the pics

I downloaded the latest version. And I tried first with clean Crystal repository. Why have to be so complicated? Can you please make the patches for me, adding only the pictrainer asm, the 2 trainer classes with the Kabutops/Aerodactyl fossils in a clean Crystal and Gold please? I'll add you in the credits.
I downloaded a 5GB tool that don't work correctly... I tried it but wouldn't work.

Last edited by Halfshadow (2018-01-14 17:20:20)


The italian Pokémon Green creator.

Offline

#21 2018-01-14 15:36:55

Halfshadow
Member
From: Italy - Lucca
Registered: 2012-04-24
Post 206/260

Re: Crystal (but also Gold) add 2 trainer classes for view the pics

Otherwise there isn't a way to do it via HEX editing? Will be easier and safe.


The italian Pokémon Green creator.

Offline

#22 2018-01-14 17:59:40

Ammako
Member
Registered: 2016-03-06
Post 141/158

Re: Crystal (but also Gold) add 2 trainer classes for view the pics

It doesn't really matter if you installed extra unneeded stuff, it simply won't be used by Cygwin when you compile.

Really all you need is default Cygwin installation, with make, git and gcc-core packages installed.

Was that error from trying to compile vanilla pokecrystal, or was that after you made the aforementioned changes to add the fossils?

Offline

#23 2018-01-14 18:03:13

Halfshadow
Member
From: Italy - Lucca
Registered: 2012-04-24
Post 207/260

Re: Crystal (but also Gold) add 2 trainer classes for view the pics

I tried only with the original untouched crystal disassembly to learn how use the tool to riassembly the roms. Or I think that is the untouched, is named Crystal master, downloaded from this link:
https://github.com/pret/pokecrystal

Last edited by Halfshadow (2018-01-14 20:11:58)


The italian Pokémon Green creator.

Offline

#24 2018-01-14 21:49:57

Crystal_
Member
From: Spain
Registered: 2012-09-16
Post 438/446
Website

Re: Crystal (but also Gold) add 2 trainer classes for view the pics

Halfshadow wrote:

Otherwise there isn't a way to do it via HEX editing? Will be easier and safe.

Definitely not easier in any way and neither safer for the hack's reliability. The only advantage of hex editing is that it teaches you some things about memory and pointers that are more abstracted in the disassembly, so that when you learn why the dissasembly is so much better, and likely restart your unmaintainable hack on it (many people been there if they don't give up earlier), you can take advantage of those little concepts that you learned.

Meanwhile, make sure to install the 64 bits version of Cygwin if your operating system is 64 bits. This may very well be the reason for the segfault.

Offline

#25 2018-01-14 21:54:56

Halfshadow
Member
From: Italy - Lucca
Registered: 2012-04-24
Post 208/260

Re: Crystal (but also Gold) add 2 trainer classes for view the pics

My OS is Windows 7 32 bits.

However IMHO is safe 'cause I'm sure of the changed bytes, I don't know if the re-assembled roms are different by the original about the offsets. I started my hack on a retail version and if the offsets are changed obviously the patch will not work.


The italian Pokémon Green creator.

Offline

  • Index
  • → Help/Question
  • → Crystal (but also Gold) add 2 trainer classes for view the pics

Board footer

Powered by FluxBB