Skeetendo

’Cause all games were better on the GBC

You are not logged in.

#51 2017-07-24 18:10:14

rbroab
Member
Registered: 2017-06-13
Post 55/68

Re: [Patch] Extension 255 icons/minis

So I was able to get the sprites working, but now I'm getting an error with the overworld portion.
I've changed route39.asm, route39barn.asm, Sprite_Constants.asm, and overworld.asm to include Miltank

But every time I go to build the rom, I get the error Unknown Symbol 'SPRITE_MILTANK'

Well I was able to build the rom...but now none of the Pokemon in the overworld don't appear correctly.
The Jigglypuff in the pokemon center was a Vaporeon, and a Nidoran was a Furret. The Miltank are displaying as Bellsprout
Anyone know how to fix this?

n5KDt5A.png

Last edited by rbroab (2017-07-24 20:03:00)

Offline

#52 2017-07-24 21:37:29

rbroab
Member
Registered: 2017-06-13
Post 56/68

Re: [Patch] Extension 255 icons/minis

Can't figure out what's going on with the Daycare Mons
Some times they work, other times they don't

IU33OUV.png?1

LVw54Vb.png?1 jXXwWZK.png?1

VUwKW0Y.png?1

Offline

#53 2017-07-24 22:06:30

Maniac379
Member
Registered: 2015-01-15
Post 103/112

Re: [Patch] Extension 255 icons/minis

See the fix to engine/mon_icons.asm

https://github.com/maniac379/White-Crys … 0098e9df2a


---
Pokémon White Crystal
A simple quality of life and gameplay improved hack

Offline

#54 2017-07-24 22:25:29

rbroab
Member
Registered: 2017-06-13
Post 57/68

Re: [Patch] Extension 255 icons/minis

I did that. I copied all of the files from the fix
And yeah I added the line "ld [CurIcon], a" to my engine/mon_icons.asm file, but it gives me the same issue

I can send you a zip of the archive just so you can see I'm not crazy
For the life of me I can't get github to work. My commits and changes won't upload


Edit; So I've made a discovery. I had to split the icons into two banks
menu/minipics1.asm
menu/minipics2.asm

Charizard is in bank 1
Tauros and Totodile are in bank 2
HOWEVER
Eevee lines up with Charizard in bank 2
Bulbasaur lines up with Tauros in bank 1
Nidoqueen lines up with Totodile in bank 1


Seems as if the sprites are being picked from both banks and switching icons instead of just one (not sure what causes the switch yet).
Ideas to fix?

Edit; and before anyone posts it again, I've already done everything within the "Fixed overworld sprites" posted by Maniac379

If someone could actually look at my scripts, it would be really helpful

Last edited by rbroab (2017-07-25 02:54:32)

Offline

#55 2017-09-15 02:15:10

SuperEgz
New member
Registered: 2017-09-01
Post 5/8

Re: [Patch] Extension 255 icons/minis

I put this into my game but Miltank is Tauros in the farm! what did I do wrong?

Last edited by SuperEgz (2017-09-15 02:15:50)

Offline

#56 2017-09-15 12:41:13

Maniac379
Member
Registered: 2015-01-15
Post 107/112

Re: [Patch] Extension 255 icons/minis

SuperEgz wrote:

I put this into my game but Miltank is Tauros in the farm! what did I do wrong?

Read the previous posts for the missing line of code that I highlighted


---
Pokémon White Crystal
A simple quality of life and gameplay improved hack

Offline

Board footer

Powered by FluxBB