Skeetendo

’Cause all games were better on the GBC

You are not logged in.

#1 2017-07-13 17:58:21

rbroab
Member
Registered: 2017-06-13
Post 43/86

Infinite Bag Space

I haven't found anything to make this work, at least not for TPPCrystal251pub
Where/what are the files I need to edit?

Offline

#2 2017-07-13 23:13:36

Rangi
Member
Registered: 2016-05-09
Post 771/870

Re: Infinite Bag Space

In constants/misc_constants.asm, edit MAX_ITEMS, MAX_KEY_ITEMS, MAX_BALLS, and MAX_PC_ITEMS. If you increase their values, you may need to remove some of the unused "ds" directives in their section of wram.asm to make space. For instance, the "ds 13" after FarfetchdPosition, or the "ds 49" after the Triggers, or the "ds 100" after the FightCounts.

For infinite space set them to ∞. :P


Pokémon Polished Crystal (GitHub) — version 2.2.0 released
Pokémon Red★ and Blue★: Space World Edition (GitHub) — updated August 19!
Polished Map: pokered+pokecrystal map, tileset, and palette editor — version 3.5.1 released!

Offline

#3 2017-07-13 23:41:07

rbroab
Member
Registered: 2017-06-13
Post 46/86

Re: Infinite Bag Space

Wait, what do you mean by removing the unused ds directives?
I guess I'm confused how the bag space and these "ds" directives are related

Offline

#4 2017-07-17 16:55:53

Crystal_
Member
From: Spain
Registered: 2012-09-16
Post 428/450
Website

Re: Infinite Bag Space

You need more space. Removing unused space declarations gives you space.

Offline

#5 2017-07-17 23:33:31

rbroab
Member
Registered: 2017-06-13
Post 48/86

Re: Infinite Bag Space

Would anyone happen to know the proper amount of unused space declarations I would need for this?
MAX_ITEMS     EQU 50
MAX_BALLS     EQU 12
MAX_KEY_ITEMS EQU 30
MAX_PC_ITEMS  EQU 60

Not quite unlimited items, but I can't imagine ever carrying 50 items at any point.
Also, how will I know if the declaration I'm removing is unused? I have no issue going through and finding them, but I'd hate to remove something important.

Offline

#6 2017-07-18 18:55:32

Crystal_
Member
From: Spain
Registered: 2012-09-16
Post 429/450
Website

Re: Infinite Bag Space

I believe these addresses aren't used at all, but there are other people here who probably know better than me

Offline

#7 2017-07-19 04:05:20

rbroab
Member
Registered: 2017-06-13
Post 49/86

Re: Infinite Bag Space

Is this link only referring to line 2649?
That's the only bit that's highlighted for me. Wasn't sure if you had more in mind than just that. Thanks!

Also, I'm using ttpcrystal251pub
It's slightly different in regards to wram.asm file

Not trying to be a pain, that's why I thought it would be better to learn the difference between what's used and what's not used. Doesn't seem like there's anyone working with the tppcrystal repo

Last edited by rbroab (2017-07-19 04:14:56)

Offline

#8 2017-07-20 12:25:20

Crystal_
Member
From: Spain
Registered: 2012-09-16
Post 430/450
Website

Re: Infinite Bag Space

I don't know about other addresses but from my experience those 100 bytes are unused. Aren't 100 bytes enough space for what you need? I don't know if those bytes may have been used in that repository though.

Last edited by Crystal_ (2017-07-20 12:25:35)

Offline

#9 2017-07-20 23:57:56

rbroab
Member
Registered: 2017-06-13
Post 53/86

Re: Infinite Bag Space

Honestly I just have no idea how to tell if certain bits are being used or not.

Offline

#10 2017-07-21 03:13:14

Mateo
Member
From: The Sims 4
Registered: 2009-11-25
Post 3,492/3,578

Re: Infinite Bag Space

Well, if space is declared and there's no label associated with it, it's probably a good sign that it isn't used for anything. Maybe not always, but I think at this point all the used ones have labels. But since you're using someone else's hack as a base and its based on an outdated version of Pokecrystal, it's really hard to say.

Last edited by Mateo (2017-07-21 03:13:45)

Offline

Board footer

Powered by FluxBB